svn commit: r260022 - head/lib/libkvm

[Konstantin Belousov]

On Sat, Dec 28, 2013 at 06:39:07PM -0800, Marcel Moolenaar wrote:
> 
> On Dec 28, 2013, at 4:40 PM, Peter Wemm <peter at wemm.org> wrote:
> 
> > On Sat, Dec 28, 2013 at 4:04 PM, Peter Wemm <peter at wemm.org> wrote:
> >> On Sat, Dec 28, 2013 at 3:01 PM, Marcel Moolenaar <marcel at freebsd.org> wrote:
> >>> Author: marcel
> >>> Date: Sat Dec 28 23:01:57 2013
> >>> New Revision: 260022
> >>> URL: http://svnweb.freebsd.org/changeset/base/260022
> >>> 
> >>> Log:
> >>>  Allow building a cross libkvm by setting TARGET_ARCH. The library so
> >>>  produced will be called libkvm-${ARCH} instead of libkvm. This allows
> >>>  installing it alongside the native version.
> >>>  For symbol lookups, use ps_pglobal_lookup() instead of __fdnlist()
> >>>  when building a cross libkvm. It is assumed that the cross tool that
> >>>  uses the cross libkvm also provides an implementation for this
> >>>  proc_services function.
> >>> 
> >>>  Note that this commit does not change any of the architecture-specific
> >>>  code for cross-compilation.
> >> 
> >> Are you sure about this? I just got a brand new buildworld failure on
> >> an amd64 machine.  The lib32 build code was trying to use 64 bit pmap
> >> definitions and failed miserably.
> >> 
> >> I'm really sorry, I accidentally blew away the failure log.  I'll have
> >> another in a few minutes.
> > 
> > 
> > This is from stage5.1, the lib32 build:
> > 
> > /usr/src/lib/libkvm/kvm_amd64.c:78:2: error: unknown type name 'pml4_entry_t'
> >        pml4_entry_t    *PML4;
> >        ^
> 
> Ugh. I'll probably revert...

Might be, it makes more sense to disable libkvm compat32 build ?
The library does not have any chance of functioning on host anyway.
The only compelling argument to keep it is to satisfy the linkage
for binaries which do not use the library.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20131229/5ad1cbe8/attachment.sig>