svn commit: r259642 - head/sys/netinet

[Gleb Smirnoff]

On Fri, Dec 20, 2013 at 07:41:03AM +0000, Adrian Chadd wrote:
A> Author: adrian
A> Date: Fri Dec 20 07:41:03 2013
A> New Revision: 259642
A> URL: http://svnweb.freebsd.org/changeset/base/259642
A> 
A> Log:
A>   Disable the now unpredicably bogus check for whether we have
A>   eneough queue space before queuing a bunch of IP fragments.
A>   
A>   As the comment in the committed change says, in the post-if_transmit(),
A>   post-SMP, post-preemption world, there's just too much overlapping
A>   concurrent code paths and different approaches to driver transmit
A>   queue management to have this code even remotely be effective.
A>   
A>   The only specific place it could be useful is if ALTQ is enabled
A>   but again it doesn't at all promise that all the fragments will be
A>   transmitted anyway.
A>   
A>   The main reason for committing this change is to disable a parallel
A>   place where the drops counter is incremented.  This is a side effect
A>   of an upcoming change to ixgbe/cxgbe to handle the queue drops
A>   counter slightly better.

I didn't get to review of actual patch, but IMO it would be better
just to remove the code, not ifdef 0 it. The code ifdefed has zero
probability to be enabled in its current form. If we ever fix it, code
would look very different.

No reason to do followup commit, that was just me muttering.

-- 
Totus tuus, Glebius.