svn commit: r259475 - head/sys/kern

Gleb Smirnoff glebius at FreeBSD.org
Tue Dec 17 01:29:37 UTC 2013


On Mon, Dec 16, 2013 at 04:54:15PM -0800, Adrian Chadd wrote:
A> Ok. I'll go find where I copy pastes thus from. The mbuf code perhaps?
A> 
A> Should we do a big quick tidy up?

Nope, the mbuf code is somewhat different, due to secondary zones. An
item freed there isn't actually freed, that's why they need a shift of
trashing memory not in ctor/dtor, but in init/fini. Actually, now I see
that your code is not only extraneous but wrong.  You probably wanted to
set ctor/dtor methods, not init/fini. So just remove it, in case of INVARIANTS
the UMA automatically does all needed trash filling and later checking.


-- 
Totus tuus, Glebius.


More information about the svn-src-head mailing list