svn commit: r259479 - head/usr.sbin/bsdinstall/scripts

[Nathan Whitehorn]

On 12/16/13 15:48, Teske, Devin wrote:
> On Dec 16, 2013, at 1:40 PM, Teske, Devin wrote:
>
>> On Dec 16, 2013, at 1:26 PM, Nathan Whitehorn wrote:
>>
>>> On 12/16/13 13:47, Devin Teske wrote:
>>>> Author: dteske
>>>> Date: Mon Dec 16 19:47:04 2013
>>>> New Revision: 259479
>>>> URL: https://urldefense.proofpoint.com/v1/url?u=http://svnweb.freebsd.org/changeset/base/259479&k=%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=Mrjs6vR4%2Faj2Ns9%2FssHJjg%3D%3D%0A&m=fW6SVzmwwyz0yNXNK7sHp4zegrL63niU%2F%2F21DVtgyGU%3D%0A&s=cdd7f18e0151f222c2934ae69e473dac2e22e74cbde4d5af5758a083fb1c3a7e
>>>>
>>>> Log:
>>>>   Add kern.geom.label.disk_ident.enable="0" to loader.conf(5).
>>>>      Discussed on:	-current, -stable
>>>>   MFC after:	3 days
>>>>
>>>> Modified:
>>>>   head/usr.sbin/bsdinstall/scripts/zfsboot
>>>>
>>>> Modified: head/usr.sbin/bsdinstall/scripts/zfsboot
>>>> ==============================================================================
>>>> --- head/usr.sbin/bsdinstall/scripts/zfsboot	Mon Dec 16 19:44:45 2013	(r259478)
>>>> +++ head/usr.sbin/bsdinstall/scripts/zfsboot	Mon Dec 16 19:47:04 2013	(r259479)
>>>> @@ -1159,6 +1159,9 @@ zfs_create_boot()
>>>> 	             $BSDINSTALL_TMPETC/rc.conf.zfs || return $FAILURE
>>>> 	f_eval_catch $funcname echo "$ECHO_APPEND" 'zfs_load=\"YES\"' \
>>>> 	             $BSDINSTALL_TMPBOOT/loader.conf.zfs || return $FAILURE
>>>> +	f_eval_catch $funcname echo "$ECHO_APPEND" \
>>>> +	             'kern.geom.label.disk_ident.enable=\"0\"' \
>>>> +	             $BSDINSTALL_TMPBOOT/loader.conf.zfs || return $FAILURE
>>>>    	# We're all done unless we should go on for boot pool
>>>> 	[ "$ZFSBOOT_BOOT_POOL" ] || return $SUCCESS
>>> Uh -- what is all of this? Why are we disabling kernel functions depending on what the root filesystem is? Please don't MFC this.
>> http://lists.freebsd.org/pipermail/freebsd-stable/2013-December/076365.html
>> http://lists.freebsd.org/pipermail/freebsd-stable/2013-December/076471.html
>>
>> NB: Happy to rip it out... but want something in-reply to those threads (pretty please).
> Basically... the logic is...
>
> The ZFS pool is built on vdevs of a specific name. The names that are used
> should remain the same. Adding this to the loader.conf ensures that the names
> that the pool(s) was/were built upon do not change.
>
> This goes beyond just a swap partition I imagine. For example... copying the
> data to a new drive using a duplicator. I'm sure there are other cases too.

Thanks for the explanation! I wonder if we should just turn off the disk 
ident stuff by default globally -- it was causing problems for me as 
well without ZFS root.
-Nathan