svn commit: r255067 - head/sys/kern

[Ian Lepore]

On Fri, 2013-08-30 at 16:55 +0300, Andriy Gapon wrote:
> on 30/08/2013 16:49 Hans Petter Selasky said the following:
> > On 08/30/13 15:37, Andriy Gapon wrote:
> >> on 30/08/2013 13:39 Hans Petter Selasky said the following:
> >>> Author: hselasky
> >>> Date: Fri Aug 30 10:39:56 2013
> >>> New Revision: 255067
> >>> URL: http://svnweb.freebsd.org/changeset/base/255067
> >>>
> >>> Log:
> >>>    Simplify pause_sbt() logic. Don't call DELAY() if remainder is less
> >>>    than or equal to zero.
> >>
> >> Discussed with?
> >> Reviewed by?
> >> Tested by?
> >>
> > 
> > Hi,
> > 
> > I've checked MAINTAINERS first.
> > 
> > A patch was sent to the freebsd-current mailing list, See XHCI USB debugging
> > thread.
> 
> I noticed that you committed the patch just a few minutes after making it
> public.  And later noticed that the patch did not result in any improvement.
> 
> > Could probably have been discussed a bit more.
> 
> Indeed.
> 
> > The cold case logic for pause()
> > is mainly used by the USB code and was factored out from usb_pause_mtx() a long
> > while ago by me.
> 
> Oh, I see.
> 
> > Do you see anything technically wrong about my patch?
> 
> I don't feel qualified enough.
> 

What I want to know is why a DELAY() loop needs to function well with
delay values longer than 1 second.  Are we really doing that?

-- Ian