svn commit: r254440 - head/usr.sbin/rwhod

Mario Oshogbo oshogbo at FreeBSD.org
Mon Aug 19 18:45:37 UTC 2013


Thank you for your commit and sorry for not repair this problem earlier.

> @@ -274,6 +274,15 @@ main(int argc, char *argv[])
>  		exit(1);
>  	if (!quiet_mode) {
>  		pid_child_receiver = pdfork(&fdp, 0);
> +		if (pid_child_receiver == -1) {
> +			if (errno != ENOSYS) {
> +				syslog(LOG_ERR, "pdfork: %m");
> +				exit(1);
> +			} else {
> +				pid_child_receiver = fork();
> +				fdp = -1;
> +			}
> +		}

We can't do it this way. pdfork() is used there to prevent killing only
one process. If we use fork() and we kill parent process the second
process (child process) will become a zombie process. I suggest to
revert this change. The changes that Pawel commit (r254486 (thx
jilles!!!) and r254480) should resolve all problems.

Cheers,
oshogbo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20130819/587e5115/attachment.sig>


More information about the svn-src-head mailing list