svn commit: r254275 - head/sys/geom/raid

Alexander Motin mav at FreeBSD.org
Tue Aug 13 09:16:31 UTC 2013


On 13.08.2013 11:48, Andriy Gapon wrote:
> on 13/08/2013 10:56 Alexander Motin said the following:
>> +	/* Deny write opens for read-only volumes. */
>> +	if (vol->v_read_only && acw > 0) {
>> +		error = EROFS;
>> +		goto out;
>> +	}
>
> I'd like to stir a small (hopefully) discussion (again, hopefully): is EROFS
> appropriate here or would ENODEV be better?
>
> EROFS	Read-only filesystem
> ENODEV	Operation not supported by device

I've seen both options and have no strong opinion here. Quick search via 
sources shown that some thing such as md(4) use EROFS. If that is wrong, 
lets fix it globally and forget.

-- 
Alexander Motin


More information about the svn-src-head mailing list