svn commit: r249800 - head/sys/dev/bwn

hiren panchasara hiren at FreeBSD.org
Mon Apr 29 16:44:06 UTC 2013


On Mon, Apr 29, 2013 at 9:19 AM, Adrian Chadd <adrian at freebsd.org> wrote:
> On 29 April 2013 08:23, John Baldwin <jhb at freebsd.org> wrote:
>>> -       dr->setdesc(dr, desc, paddr, meta->mt_m->m_len -
>>> +       dr->setdesc(dr, desc, meta->mt_paddr, meta->mt_m->m_len -
>>>             sizeof(*hdr), 0, 0, 0);
>>>         return (error);
>>>  }
>>
>> I would leave the comment alone.  In the common case you do allocate a new
>> mbuf so you aren't restoring the descriptor but setting it up with a new
>> address.  The code change looks correct.

Alright. Thanks John.
>
> Does anyone here have bwn hardware that works?

I do not.

Hiren
>
>
>
> Adrian


More information about the svn-src-head mailing list