svn commit: r250037 - head/bin/hostname

Ed Schouten ed at 80386.nl
Mon Apr 29 14:50:07 UTC 2013


Hi Bruce,

2013/4/29 Bruce Evans <brde at optusnet.com.au>:
> - usr.bin/rlogin/rlogin.c has it in a gratuitously different form, as
>   'static _Noreturn void        usage(void);'.  This is bogus since
>   _Noreturn is a wrapper for a new C++ feature

I hate to correct you here, but _Noreturn is not a wrapper for a new
C++ feature, it's a keyword that's part of C11. See:

http://en.wikipedia.org/wiki/C11_(C_standard_revision)#Changes_from_C99

All C11 keywords can be implemented on top of GCC-specific constructs,
with the exception of _Generic. I would strongly prefer it if we used
these keywords over our FreeBSD-specific solutions.

If the only objection is the spelling of these keywords (underscores,
uppercase, etc), be sure to:

#include <stdalign.h> /* For alignas/alignof. */
#include <stdnoreturn.h> /* For noreturn. */
#include <threads.h> /* For thread_local. */

--
Ed Schouten <ed at 80386.nl>


More information about the svn-src-head mailing list