svn commit: r248644 - head/cddl/contrib/opensolaris/lib/libdtrace/common

[Andriy Gapon]

on 21/04/2013 06:08 Mark Johnston said the following:
> On Sat, Mar 23, 2013 at 08:57:54AM +0000, Andriy Gapon wrote:
>> Author: avg
>> Date: Sat Mar 23 08:57:54 2013
>> New Revision: 248644
>> URL: http://svnweb.freebsd.org/changeset/base/248644
>>
>> Log:
>>   dtrace: ensure that we can always catch a process (e.g. when -c is used)
>>   
>>   It is not guaranteed that a program has a symbol table entry for main
>>   and thus that it would be possible to set a breakpoint on it.
>>   
>>   Reviewed by:	rpaulo
>>   Discussed with:	rpaulo
>>   MFC after:	13 days
> 
> Hi Andriy,
> 
> This commit seems to break USDT for me. When I for instance try to run
> the toy example at https://wiki.freebsd.org/DTrace/userland (the
> database provider), I get
> 
> markj at gloom: ~/tmp/dtrace/db $ sudo dtrace -s db.d -c ./db
> dtrace: failed to compile script db.d: line 2: probe description database23147:::query-start does not match any probes
> 
> When I revert this commit and recompile the example program and
> libdtrace, it works as expected.

Mark,

thank you very much for the report.
It seems that I didn't fully understand consequences of the change when I made
it.  I am still looking into the details of the relevant differences between
Solaris/Illumos and FreeBSD.
Because I am going on a vacation I've decided to revert this commit for now.

-- 
Andriy Gapon