svn commit: r249355 - head/lib/libkvm

[Gleb Smirnoff]

  Juli,

On Thu, Apr 11, 2013 at 11:05:28AM -0700, Juli Mallett wrote:
J> > On Thu, Apr 11, 2013 at 09:07:25PM +1000, Bruce Evans wrote:
J> > B> Just routine avoidance of namespace pollution.  This is easy in such a
J> > B> simple header.
J> >
J> > Sorry, with all respect, but I can't call including sys/types.h
J> > a namespace pollution.
J> >
J> > Ok, even you force me to name it that way, still I would prefer
J> > namespace pollution instead of handmade copy pasted typedefs.
J> 
J> But Gleb, making such changes unilaterally is a bit of a leap.  The
J> project has mostly accepted Bruce's wisdom about trying to minimize
J> and reduce namespace pollution.  Now, this isn't a standard header so
J> it's quite a bit less of a concern, but it's not no concern.  If you
J> think that we should reverse our trend on including
J> namespace-polluting headers in system headers, we should discuss that
J> on arch@, and it shouldn't be something that's done without any
J> discussion or consideration.
J> 
J> Should we expect further changes of this nature (and of the proposed
J> nature removing __size_t and __ssize_t use) if you make changes to
J> other headers as part of your work?  Are you going to add
J> <sys/types.h> to every header currently using <sys/_types.h> in a
J> single go, or will you be doing that a little at a time when making
J> functional changes?

Your suggestion? Typedef standard uint64_t manually as size_t and ssize_t
already are done? Can you please define amount of standard types needed
for kvm.h (or any abstract header) that would give a permission to include
sys/types.h instead of typedefing all these types via a cut-n-paste
surrounded by ifdefs?

I am all against namespace pollution, but not when it comes to sys/types.h.

-- 
Totus tuus, Glebius.