svn commit: r249355 - head/lib/libkvm

Gleb Smirnoff glebius at FreeBSD.org
Thu Apr 11 09:14:20 UTC 2013


On Thu, Apr 11, 2013 at 06:49:02PM +1000, Bruce Evans wrote:
B> > On Thu, Apr 11, 2013 at 05:59:24PM +1000, Bruce Evans wrote:
B> > B> > Modified:
B> > B> >  head/lib/libkvm/kvm.h
B> > B> >
B> > B> > Modified: head/lib/libkvm/kvm.h
B> > B> > ==============================================================================
B> > B> > --- head/lib/libkvm/kvm.h	Thu Apr 11 07:02:27 2013	(r249354)
B> > B> > +++ head/lib/libkvm/kvm.h	Thu Apr 11 07:30:49 2013	(r249355)
B> > B> > @@ -34,7 +34,7 @@
B> > B> > #define	_KVM_H_
B> > B> >
B> > B> > #include <sys/cdefs.h>
B> > B> > -#include <sys/_types.h>
B> > B>
B> > B> The __uintXX_t types are declared here, and should be used, like the
B> > B> __Xsize_t types already are.
B> >
B> > Why non-standard types should be used instead of standard ones?
B> 
B> Sometimes because the namespace doesn't allow the standard ones, but
B> here I was just saying to typedef just the standard ones that you need
B> (only uint64_t?) as is done for size_t and ssize_t.  Including
B> <sys/types.h> also turns the careful ifdefs for the latter into
B> no-ops.

What was the reason to avoid including types.h and typedefing size_t
and ssize_t manually?

-- 
Totus tuus, Glebius.


More information about the svn-src-head mailing list