svn commit: r249000 - head/sys/dev/ath

Adrian Chadd adrian at FreeBSD.org
Tue Apr 2 06:25:11 UTC 2013


Author: adrian
Date: Tue Apr  2 06:25:10 2013
New Revision: 249000
URL: http://svnweb.freebsd.org/changeset/base/249000

Log:
  Mark a couple of places where I think the dmamap isn't being unmapped
  before the TX path is being aborted.
  
  Right now it's in the TDMA code and I can live with that; but it really
  should get fixed.
  
  I'll do a more thorough audit of this code soon.

Modified:
  head/sys/dev/ath/if_ath_tx.c

Modified: head/sys/dev/ath/if_ath_tx.c
==============================================================================
--- head/sys/dev/ath/if_ath_tx.c	Tue Apr  2 06:24:22 2013	(r248999)
+++ head/sys/dev/ath/if_ath_tx.c	Tue Apr  2 06:25:10 2013	(r249000)
@@ -1615,6 +1615,7 @@ ath_tx_normal_setup(struct ath_softc *sc
 		if_printf(ifp, "bogus frame type 0x%x (%s)\n",
 			wh->i_fc[0] & IEEE80211_FC0_TYPE_MASK, __func__);
 		/* XXX statistic */
+		/* XXX free tx dmamap */
 		ath_freetx(m0);
 		return EIO;
 	}
@@ -1670,6 +1671,7 @@ ath_tx_normal_setup(struct ath_softc *sc
 		DPRINTF(sc, ATH_DEBUG_TDMA,
 		    "%s: discard frame, ACK required w/ TDMA\n", __func__);
 		sc->sc_stats.ast_tdma_ack++;
+		/* XXX free tx dmamap */
 		ath_freetx(m0);
 		return EIO;
 	}


More information about the svn-src-head mailing list