svn commit: r240938 - head/sys/net

Gleb Smirnoff glebius at FreeBSD.org
Wed Sep 26 06:58:26 UTC 2012


On Wed, Sep 26, 2012 at 10:56:15AM +0400, Gleb Smirnoff wrote:
T>   Ed,
T> 
T> On Tue, Sep 25, 2012 at 10:10:14PM +0000, Ed Maste wrote:
T> E> Author: emaste
T> E> Date: Tue Sep 25 22:10:14 2012
T> E> New Revision: 240938
T> E> URL: http://svn.freebsd.org/changeset/base/240938
T> E> 
T> E> Log:
T> E>   Avoid INVARIANTS panic destroying an in-use tap(4)
T> E>   
T> E>   The requirement (implied by the KASSERT in tap_destroy) that the tap is
T> E>   closed isn't valid; destroy_dev will block in devdrn while other threads
T> E>   are in d_* functions.
T> E>   
T> E>   Note: if_tun had the same issue, addressed in SVN revisions r186391,
T> E>   r186483 and r186497.  The use of the condvar there appears to be
T> E>   redundant with the functionality provided by destroy_dev.
T> 
T> So why did you add condvar to the softc? See it in diff below.

Noticed later commit, sorry for noise.

-- 
Totus tuus, Glebius.


More information about the svn-src-head mailing list