svn commit: r242161 - in head/sys: net netinet netpfil/pf

Andre Oppermann andre at freebsd.org
Sat Oct 27 10:59:08 UTC 2012


On 26.10.2012 23:06, Gleb Smirnoff wrote:
> Author: glebius
> Date: Fri Oct 26 21:06:33 2012
> New Revision: 242161
> URL: http://svn.freebsd.org/changeset/base/242161
>
> Log:
>    o Remove last argument to ip_fragment(), and obtain all needed information
>      on checksums directly from mbuf flags. This simplifies code.
>    o Clear CSUM_IP from the mbuf in ip_fragment() if we did checksums in
>      hardware. Some driver may not announce CSUM_IP in theur if_hwassist,
>      although try to do checksums if CSUM_IP set on mbuf. Example is em(4).

I'm not getting your description here?  Why work around a bug in a driver
in ip_fragment() when we can fix the bug in the driver?

>    o While here, consistently use CSUM_IP instead of its alias CSUM_DELAY_IP.
>      After this change CSUM_DELAY_IP vanishes from the stack.

Good. :)

>    Submitted by:	Sebastian Kuzminsky <seb lineratesystems.com>

-- 
Andre



More information about the svn-src-head mailing list