svn commit: r241701 - in head/usr.sbin/bsdconfig: . include share

[Devin Teske]

On Oct 21, 2012, at 11:10 AM, Alexey Dokuchaev wrote:

> On Fri, Oct 19, 2012 at 11:36:04AM -0700, Devin Teske wrote:
>> On Oct 19, 2012, at 10:02 AM, Alexey Dokuchaev wrote:
>>> Ah, I guess it might explain the shitty colors I see on newish FreeBSD
>>> screenshots of dialog(1).
>> 
>> I actually prefer the colors in cdialog (more specifically, I prefer the
>> lack-of-yellow!).
>> 
>> I'm curious about how others feel about the use of yellow (specifically
>> that old dialog(1)/libdialog used it a lot and new cdialog-based dialog(1)/
>> libdialog doesn't use it hardly at all).
> 
> While you probably know my opinion at this point, I'd like to remark that our
> original dialog(1) colors seem like one of our distinctive features (similar
> to e.g. RedHat's or Debian's text-based installers) that had been around for
> years and are immediately recognizable.  It is sad to loose them.
> 

Hmm, you make an interesting point and I think I know why the change in colors.

I saw this hit my inbox recently:

%begin excerpt%
--- head/contrib/dialog/CHANGES	Sun Oct 21 18:18:49 2012	(r241817)
+++ head/contrib/dialog/CHANGES	Sun Oct 21 18:25:12 2012	(r241818)
@@ -1,9 +1,172 @@
--- $Id: CHANGES,v 1.360 2011/07/07 23:35:10 tom Exp $
+-- $Id: CHANGES,v 1.419 2012/07/06 18:18:48 tom Exp $
-- Thomas E. Dickey <dickey at invisible-island.net>

This version of dialog was originally from a Debian snapshot.  I've done this
to it:

%end excerpt%

The dialog(1) that we're using in 9+ was originally from Debian and then "tom" makes a bunch of modifications (and I think our own nwhitehorn might make some more changes).

I think this explains the [recent] similarity in color choices.

I think you make a good point about diminished diversity. However, I'd inquire with nwhitehorn about any/all changes to the dialog(1) contrib code as it is still vendor maintained (and he's the one doing the importing these days).



>> It is possible to change the colorings by first creating (if you don't
>> already have one) a ~/.dialogrc by executing the below command:
>> 
>> dialog --create-rc ~/.dialogrc
>> 
>> followed by editing said file.
>> 
>> So while the default look and feel has changed, it's possible to customize
>> it to your liking.
> 
> I would wholeheartedly prefer us to have original colors by default, and to

Changing the default colors introduces [more] maintenance for the importer/maintainer of the contrib code. Exactly how much more maintenance, I'm unsure of.


> provide alternative color scheme for those how experience some difficulties
> with them (e.g. MacOSX users), not the other way around.
> 

Mac OS X was only one example, and I agree it should not be the sole source of reasoning here. However, I experience the same problem using XTerm natively on FreeBSD. My personal issue although has already been heard on the topic (unable to see the yellow titles, yellow hlines, or pretty much any yellow on a light background) -- so I'm inclined to not push too hard in restoring the original coloring _exactly_ as it was (read: I think we can do better).
-- 
Devin

_____________
The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.