svn commit: r241916 - in head/sys: netinet netinet6

Bruce Evans brde at optusnet.com.au
Tue Oct 23 18:28:40 UTC 2012


On Tue, 23 Oct 2012, Michael Tuexen wrote:

> On Oct 23, 2012, at 6:23 AM, Bruce Evans wrote:
>
>> On Mon, 22 Oct 2012, Xin LI wrote:
>>
>>> Log:
>>> Remove __P.
>>
>> This was a chance to remove style bugs in the prototypes.  At least it
>> didn't create so many new ones, unlike the original __P axing.  It
>> still enlarged about a hundred by changing from Gnu style continuation
>> to Gnu style continuation indentation with an off-by-5 error.
>
> please note that the SCTP code in the FreeBSD sources is generated
> via an export script from a codebase which runs on multiple platforms.
> The script tries to follow FreeBSDs guidelines, but is far from being
> perfect.

The export script might not like manual editing of its output.

Portability might require __P(()), and then removing it cleaning requires
a complicated script.

Bruce


More information about the svn-src-head mailing list