svn commit: r241546 - head/sys/contrib/ipfilter/netinet

[Jilles Tjoelker]

On Mon, Oct 15, 2012 at 06:36:58PM +0400, Gleb Smirnoff wrote:
> On Mon, Oct 15, 2012 at 08:34:09AM -0400, John Baldwin wrote:
> J> On Sunday, October 14, 2012 11:03:07 am Gleb Smirnoff wrote:
> J> > Author: glebius
> J> > Date: Sun Oct 14 15:03:06 2012
> J> > New Revision: 241546
> J> > URL: http://svn.freebsd.org/changeset/base/241546

> J> > Log:
> J> >   Fix defines in r241245. We actually don't define FreeBSD.

> J> >   Reported & tested by:	Oleg Ginzburg

> J> Seems like it should be using 'defined(__FreeBSD_version)' instead?

> AFAIU, the construction which left after r241546 works fine. Anything
> undefined resolves to zero, so in case of non-FreeBSD build we test
> if (0 > 10000019) and this fails which is what we expect.

> I have used this construction several times already without any side
> effects. I have also seen it in some software in ports, where it works
> okay, too.

The C standard indeed permits this, but gcc -Wundef will warn about it.
That compiler warning is in CWARNFLAGS in sys/conf/kern.mk so I suggest
adding the 'defined(__FreeBSD_version) &&'.

-- 
Jilles Tjoelker