svn commit: r241140 - head/sys/kern

Garrett Cooper yanegomi at gmail.com
Tue Oct 2 20:50:03 UTC 2012


On Tue, Oct 2, 2012 at 12:38 PM, Gleb Smirnoff <glebius at freebsd.org> wrote:
> On Tue, Oct 02, 2012 at 06:38:05PM +0000, Garrett Wollman wrote:
> G> Author: wollman
> G> Date: Tue Oct  2 18:38:05 2012
> G> New Revision: 241140
> G> URL: http://svn.freebsd.org/changeset/base/241140
> G>
> G> Log:
> G>   Fix spelling of the function name in two assertion messages.
> G>
> G> Modified:
> G>   head/sys/kern/uipc_socket.c
> G>
> G> Modified: head/sys/kern/uipc_socket.c
> G> ==============================================================================
> G> --- head/sys/kern/uipc_socket.c      Tue Oct  2 17:46:32 2012        (r241139)
> G> +++ head/sys/kern/uipc_socket.c      Tue Oct  2 18:38:05 2012        (r241140)
> G> @@ -995,9 +995,9 @@ sosend_dgram(struct socket *so, struct s
> G>      int atomic = sosendallatonce(so) || top;
> G>  #endif
> G>
> G> -    KASSERT(so->so_type == SOCK_DGRAM, ("sodgram_send: !SOCK_DGRAM"));
> G> +    KASSERT(so->so_type == SOCK_DGRAM, ("sosend_dgram: !SOCK_DGRAM"));
> G>      KASSERT(so->so_proto->pr_flags & PR_ATOMIC,
> G> -        ("sodgram_send: !PR_ATOMIC"));
> G> +        ("sosend_dgram: !PR_ATOMIC"));
> G>
> G>      if (uio != NULL)
> G>              resid = uio->uio_resid;
>
> Why not to use just __func__ here?

    Just reiterating the argument that was posed before: it's harder
to grep that way (even though, technically one could do better with
__func__ and __LINE__, etc if they were truly looking for
readability).
Thanks,
-Garrett


More information about the svn-src-head mailing list