svn commit: r243665 - head/sbin/dump

[Konstantin Belousov]

On Thu, Nov 29, 2012 at 05:16:50AM +0000, Eitan Adler wrote:
> Author: eadler
> Date: Thu Nov 29 05:16:50 2012
> New Revision: 243665
> URL: http://svnweb.freebsd.org/changeset/base/243665
> 
> Log:
>   Mark non-returning function as such
>   
>   PR:		bin/172978
>   Approved by:	cperciva
>   MFC after:	3 days
> 
> Modified:
>   head/sbin/dump/dump.h
> 
> Modified: head/sbin/dump/dump.h
> ==============================================================================
> --- head/sbin/dump/dump.h	Thu Nov 29 03:48:39 2012	(r243664)
> +++ head/sbin/dump/dump.h	Thu Nov 29 05:16:50 2012	(r243665)
> @@ -121,7 +121,7 @@ void	trewind(void);
>  void	writerec(char *dp, int isspcl);
>  
>  void	Exit(int status) __dead2;
> -void	dumpabort(int signo);
> +void	dumpabort(int signo) __dead2;
>  void	dump_getfstab(void);
>  
>  char	*rawname(char *cp);
What is the goal of this change ?

It is arguably backward. There is absolutely no use to mark signal handler
as __dead2, and all other uses do not benefit from the redundand declaration.
Also, being quite removed from the function definition, there is a chance
that some future modification would make the attribute a lie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20121129/04b6e8e9/attachment.sig>