svn commit: r236137 - head/contrib/gcc/config/i386

[Konstantin Belousov]

On Sun, May 27, 2012 at 10:31:00PM +0200, Roman Divacky wrote:
> Fwiw, to enable the same thing in clang you want this simple patch:
> 
> ===================================================================
> --- Tools.cpp   (revision 157545)
> +++ Tools.cpp   (working copy)
> @@ -4794,6 +4794,7 @@
>    if (Args.hasArg(options::OPT_static)) {
>      CmdArgs.push_back("-Bstatic");
>    } else {
> +    CmdArgs.push_back("--hash-style=both");
>      if (Args.hasArg(options::OPT_rdynamic))
>        CmdArgs.push_back("-export-dynamic");
>      CmdArgs.push_back("--eh-frame-hdr");
> 
> 
> 
> I cant commit this upstream as this option doesn't work with ld 2.15. What
> should be done here? Commit this to local FreeBSD version? Commit it upstream
> making it not work with old ld? Leave it out completely?
I cannot answer this question.

This should be discussed with our in-tree clang maintainers.

> 
> On Sun, May 27, 2012 at 05:27:48AM +0000, Konstantin Belousov wrote:
> > Author: kib
> > Date: Sun May 27 05:27:47 2012
> > New Revision: 236137
> > URL: http://svn.freebsd.org/changeset/base/236137
> > 
> > Log:
> >   Enable gnu hash generation for dynamic ELF binaries on x86.
> >   
> >   Reviewed by:	kan
> > 
> > Modified:
> >   head/contrib/gcc/config/i386/freebsd.h
> >   head/contrib/gcc/config/i386/freebsd64.h
> > 
> > Modified: head/contrib/gcc/config/i386/freebsd.h
> > ==============================================================================
> > --- head/contrib/gcc/config/i386/freebsd.h	Sun May 27 05:24:53 2012	(r236136)
> > +++ head/contrib/gcc/config/i386/freebsd.h	Sun May 27 05:27:47 2012	(r236137)
> > @@ -49,6 +49,7 @@ Boston, MA 02110-1301, USA.  */
> >  	%{rdynamic: -export-dynamic} \
> >  	%{!dynamic-linker:-dynamic-linker %(fbsd_dynamic_linker) }} \
> >        %{static:-Bstatic}} \
> > +    %{!static:--hash-style=both} \
> >      %{symbolic:-Bsymbolic}"
> >  
> >  /* Reset our STARTFILE_SPEC which was properly set in config/freebsd.h
> > 
> > Modified: head/contrib/gcc/config/i386/freebsd64.h
> > ==============================================================================
> > --- head/contrib/gcc/config/i386/freebsd64.h	Sun May 27 05:24:53 2012	(r236136)
> > +++ head/contrib/gcc/config/i386/freebsd64.h	Sun May 27 05:27:47 2012	(r236137)
> > @@ -54,4 +54,5 @@ Boston, MA 02110-1301, USA.  */
> >          %{rdynamic:-export-dynamic} \
> >  	%{!dynamic-linker:-dynamic-linker %(fbsd_dynamic_linker) }} \
> >      %{static:-Bstatic}} \
> > +  %{!static:--hash-style=both} \
> >    %{symbolic:-Bsymbolic}"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20120527/464a750c/attachment-0001.pgp