svn commit: r235301 - head/sys/kern

Xin LI delphij at gmail.com
Sat May 12 00:04:01 UTC 2012


On Fri, May 11, 2012 at 4:43 PM, Xin LI <delphij at freebsd.org> wrote:
> Author: delphij
> Date: Fri May 11 23:43:32 2012
> New Revision: 235301
> URL: http://svn.freebsd.org/changeset/base/235301
>
> Log:
>  Revert previous revision, misunderstood the code :(
>
> Modified:
>  head/sys/kern/kern_kthread.c
>
> Modified: head/sys/kern/kern_kthread.c
> ==============================================================================
> --- head/sys/kern/kern_kthread.c        Fri May 11 23:41:52 2012        (r235300)
> +++ head/sys/kern/kern_kthread.c        Fri May 11 23:43:32 2012        (r235301)
> @@ -182,7 +182,6 @@ kproc_suspend(struct proc *p, int timo)
>                return (EINVAL);
>        }
>        SIGADDSET(p->p_siglist, SIGSTOP);
> -       PROC_UNLOCK(p);
>        wakeup(p);
>        return msleep(&p->p_siglist, &p->p_mtx, PPAUSE | PDROP, "suspkp", timo);

For the record, p->p_mtx is the mutex used by PROC_[UN]LOCK(), which
has to be held while calling msleep().

Cheers,
-- 
Xin LI <delphij at delphij.net> https://www.delphij.net/
FreeBSD - The Power to Serve! Live free or die


More information about the svn-src-head mailing list