svn commit: r237624 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/c...

[David O'Brien]

On Wed, Jun 27, 2012 at 04:39:30AM +0000, Pedro F. Giffuni wrote:
> Log:
>   Bring llquantize support into Dtrace.
>   Bryan Cantrill implemented the equivalent of semi-log graph
>   paper for Dtrace so llquantize will use one logarithmic and
>   one linear scale.
...
>   Obtained from:	Illumos
...
> Added: head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_FACTOREVEN.nodivide.d
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize/err.D_LLQUANT_FACTOREVEN.nodivide.d	Wed Jun 27 04:39:30 2012	(r237624)
> @@ -0,0 +1,29 @@
> +/*
> + * CDDL HEADER START
> + *
> + * The contents of this file are subject to the terms of the
> + * Common Development and Distribution License (the "License").
> + * You may not use this file except in compliance with the License.
...
> +/*
> + * Copyright (c) 2011, Joyent, Inc. All rights reserved.
> + */

Pedro,
It looks like you simply 'svn add'ed this file, rather than importing it
into '^/vendor/opensolaris/dist'.  Please correct me if I am wrong.

We've become rather sloppy in the past 1-2 years in our handling of
3rd-party externally developed code.  Something we need to return to
our older ways good ways of handling.

This is something that is especially important with GPL, CDDL, and
similar licenses.

Commercial entities that base products on FreeBSD have to worry about
code provenance for various intellectual property legal reasons and we
muddy the waters when we make it harder to track who and where code came
from.
[Please see http://www.osgeo.org/incubator/process/codereview.html &
http://wiki.osgeo.org/wiki/Code_Provenance_Review to better understand
this issue.]

Not following our established procedure also means that the average
developer(committer) and commercial consumer will have their expectations
fail.  One expects to be able to find the stock vendor sources in
ssh://svn.freebsd.org/base/vendor/ and to be able to find FreeBSD local
changes to the sources thru 'svn diff' against 'ssh://svn.freebsd.org/base/head'.

Please correct this by properly importing the sources, 'svn delete'ing
the files you 'svn add'ed, and do an 'svn copy' of the new files.

thanks,
-- 
-- David  (obrien at FreeBSD.org)