svn commit: r238621 - head/sys/dev/sym

Marius Strobl marius at FreeBSD.org
Thu Jul 19 14:43:46 UTC 2012


Author: marius
Date: Thu Jul 19 14:43:46 2012
New Revision: 238621
URL: http://svn.freebsd.org/changeset/base/238621

Log:
  Revert the use of BUS_DMA_ALLOCNOW when creating the DMA tag for user
  data introduced in r236061. Using that flag doesn't make that much
  sense on this case as the DMA maps using it are also created during
  sym_pci_attach(). Moreover, due to the maxsegsz parameter used, doing
  so may exhaust the bounce pages pool on architectures requiring
  bounce pages. [1]
  While at it, use a slightly more appropriate maxsegsz parameter.
  
  PR:		169526
  Submitted by:	Mike Watters [1]
  MFC after:	3 days

Modified:
  head/sys/dev/sym/sym_hipd.c

Modified: head/sys/dev/sym/sym_hipd.c
==============================================================================
--- head/sys/dev/sym/sym_hipd.c	Thu Jul 19 13:00:31 2012	(r238620)
+++ head/sys/dev/sym/sym_hipd.c	Thu Jul 19 14:43:46 2012	(r238621)
@@ -8537,8 +8537,8 @@ sym_pci_attach(device_t dev)
 	 */
 	if (bus_dma_tag_create(np->bus_dmat, 1, SYM_CONF_DMA_BOUNDARY,
 	    BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL,
-	    BUS_SPACE_MAXSIZE, SYM_CONF_MAX_SG, SYM_CONF_DMA_BOUNDARY,
-	    BUS_DMA_ALLOCNOW, busdma_lock_mutex, &np->mtx, &np->data_dmat)) {
+	    BUS_SPACE_MAXSIZE_32BIT, SYM_CONF_MAX_SG, SYM_CONF_DMA_BOUNDARY,
+	    0, busdma_lock_mutex, &np->mtx, &np->data_dmat)) {
 		device_printf(dev, "failed to create DMA tag.\n");
 		goto attach_failed;
 	}


More information about the svn-src-head mailing list