svn commit: r230353 - head/usr.sbin/makefs

[Andreas Tobler]

On 25.01.12 06:50, Garrett Cooper wrote:
> On Tue, Jan 24, 2012 at 9:35 PM, Andreas Tobler<andreast at freebsd.org>  wrote:
>>
>
> ...
>
>> It is actually r230354, this is the commit which shows the failure.
>> And I reverted back to 230353 and onfirmed that it 'works'.
>>
>> I additionally built with -O0 -g, see below.
>>
>> If you need more details, I'll be out the next 15h but later on I can
>> continue.
>>
>> Thank you very much!
>> Andreas
>>
>> Here the output from the binary built with "-g":
>> ------
>> [andreast at tcx58] /export/home/andreast/>  printf "run -t cd9660 -o chrp-boot
>> -o rockridge -o label=pseries -B4321 p.iso /export/netboot/powerpc64/\nbt\nf
>> 1\n f 2\n" | gdb -x /dev/stdin -batch /usr/sbin/makefs
>
> ...
>
>> delete_chars);
>
>      1. What does 'list' say for that frame (the line numbers are misleading)?
>      2. What compiler are you using to compile the binary?

1.)

Starting program: /usr/sbin/makefs -t cd9660 -o chrp-boot -o rockridge 
-o label=pseries -B4321 p.iso /export/netboot/powerpc64

Program received signal SIGSEGV, Segmentation fault.
0x0000000800b781d6 in memcpy () from /lib/libc.so.7
(gdb) l
85		struct stat	 sb;
86		struct timeval	 start;
87		fstype_t	*fstype;
88		fsinfo_t	 fsoptions;
89		fsnode		*root;
90		int	 	 ch, len;
91		char		*subtree;
92		char		*specfile;
93	
94		setprogname(argv[0]);
(gdb) up
#1  0x00000000004045f8 in cd9660_rename_filename (iter=0x0, num=36,
     delete_chars=2) at /export/devel/fbsd/src/usr.sbin/makefs/cd9660.c:1120
1120			memcpy(tmp, (iter->o_name), numbts);
(gdb) l
1115				}
1116			}
1117			*/
1118	
1119			/* (copying just the filename before the '.' */
1120			memcpy(tmp, (iter->o_name), numbts);
1121	
1122			/* adding the appropriate number following the name */
1123			temp = i;
1124			while (digits > 0) {

2.)
gcc -v
Using built-in specs.
Target: amd64-undermydesk-freebsd
Configured with: FreeBSD/amd64 system compiler
Thread model: posix
gcc version 4.2.1 20070831 patched [FreeBSD]

Thanks!
Andreas