svn commit: r230354 - head/usr.sbin/makefs

[Hiroki Sato]

Eitan Adler <eadler at freebsd.org> wrote
  in <CAF6rxg=VWzUcDuk_oN_wepJPejg8JnGBKm5oLXB7Y8JCW52t3w at mail.gmail.com>:

ea> I was was unaware this code was contributed. I just looked at the
ea> NetBSD version and I don't think it suffers from the same problem -
ea> the loop appears to be used later. If that is because of some other

 Just checking, but the variables dot and semi are not used even in
 the NetBSD version since the initial import (in the NetBSD tree).
 What is "the same problem" you mentioned here?  The problem I pointed
 out is just "removing the useless loop would be good but leaving the
 related comments is bad"...

ea> bug fix which could be upstreamed that would be great. On the other
ea> hand I would like to continue with my goal of making the non-contrib
ea> world compilable with CC=gcc46.
ea>
ea> Should I revert this commit?

 I don't think it is needed.  The makefs utility is a special case
 because it will probably diverge from the upstream to support
 FreeBSD-specific feature in the future (this is one of the reasons
 why it is not in contrib/).  It didn't happen so far, however.

 By the way, does gcc46 no longer allow unused code?  Generally
 speaking, I think it is enough to clean up unused code only when we
 actually change the code.

-- Hiroki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20120123/bdc43116/attachment.pgp