svn commit: r230230 - head/sys/dev/random

[Mark Murray]

Andrey Chernov writes:
> > Should be in a header file, nad _possibly_ should be volatile. If it
> > works without being volatile, then OK.
> 
> It was preliminary patch just to confirm/deny my understanding of your 
> idea.

Ah, OK - in which case you got the idea correctly!

> I'll put it into header.

Cool.

> In the final version I also plan to move that lines
> +               if (arc4rand_iniseed_state == 1)
> +                       arc4rand_iniseed_state = -1;
> into arc4_randomstir() where they will be protected with mutex lock, so 
> volatile will be not needed. It will be more logical, because other 
> reseeding conditions are resetted there too.

Great.

> > The rest is OK. I've not tested it, so this is not a review, simply an
> > "OK" :-)
> 
> Thanx for review! I'll send final version to this thread a bit 
> later when I'll find more free time.

No problem.

M
--
Mark R V Murray
Cert APS(Open) Dip Phys(Open) BSc Open(Open) BSc(Hons)(Open)
Pi: 132511160