svn commit: r230007 - in head: etc etc/rc.d share/man/man8

[John Baldwin]

On Thursday, January 12, 2012 9:35:05 am Eygene Ryabinkin wrote:
> Thu, Jan 12, 2012 at 07:48:28AM -0500, John Baldwin wrote:
> > Alternatively, devd could have invoked a wrapper script that only
> > ran /etc/rc.d/dhclient if dhcpif was true for the interface.  All
> > other uses of /etc/rc.d/dhclient in our system scripts are
> > conditional on that check.
> 
> True, and it was suggested by Doug Barton.  But why bother when
> the 'quiet' keyword is reserved for such cases?

Hmm, that's not quite how I see this.  Either /etc/rc.d/dhclient
should silently exit if dhcpif is not true for the given interface,
or it should always whine IMO.  Given that everywhere else uses
dhcpif to decide if dhclient should be run, it seems that an explicit
test of that should be used here as well, even if it means an extra
script.  In short, this approach is not consisent with all other
users of the dhclient script, and this seems a hackish approach whose
primary goal is to avoid having devd use a wrapper script.  Perhaps
that goal is worth the tradeoff, but it's not really clean.

By your argument, btw since we use quietstart during boot, ifn_start
shouldn't even check dhcpif at all now, but just always run the
dhclient script (and if you did make that change, I would protest that
it was very wrong).

-- 
John Baldwin