svn commit: r228985 - head/sys/boot/forth

Sergey Kandaurov pluknet at freebsd.org
Mon Jan 9 20:31:12 UTC 2012


On 9 January 2012 16:49, Dimitry Andric <dim at freebsd.org> wrote:
> On 2012-01-08 21:35, Sergey Kandaurov wrote:
> ...
>
>> So, the problem arise when beastie_disable is set.
>>
>> In this case menu.rc is not evaluated and consequently menu-unset does
>> not have a body yet. This results in the ficl warning "not found" when
>> try-menu-unset calls menu-unset. The warning cannot be handled with catch
>> as seen with the code in head.
>> Otherwise, when beastie is enabled, all works as it should.
>>
>> To "fix" the problem I replaced 'catch' with 'sfind', so that we can
>> conditionally call menu-unset only when the definition is present.
>>
>> Please try the following patch. I tested it with enabled/disabled beastie
>> and loader_color over serial console. I would also like to get a review
>> from Devin Teske to see if this change is acceptable.
>
>
> Yes, this patch makes the warning disappear.  Thanks!

FYI, committed in r229881. Thanks for the help.

-- 
wbr,
pluknet


More information about the svn-src-head mailing list