svn commit: r228990 - in head/usr.sbin: IPXrouted adduser bluetooth/btpand bluetooth/sdpd bootparamd/bootparamd bsnmpd/modules/snmp_bridge bsnmpd/modules/snmp_hostres bsnmpd/modules/snmp_wlan bsnmp...

[Ulrich Spoerlein]

On Fri, 2011-12-30 at 14:43:22 -0500, Ben Kaduk wrote:
> On Fri, Dec 30, 2011 at 5:58 AM, Ulrich Spoerlein <uqs at freebsd.org> wrote:
> > Modified: head/usr.sbin/cron/doc/CHANGES
> > ==============================================================================
> > --- head/usr.sbin/cron/doc/CHANGES      Fri Dec 30 10:45:00 2011        (r228989)
> > +++ head/usr.sbin/cron/doc/CHANGES      Fri Dec 30 10:58:14 2011        (r228990)
> > @@ -1,3 +1,6 @@
> > +$FreeBSD$
> > +--------
> > +
> >  Vixie Cron             Changes from V2 to V3
> >  Paul Vixie
> >  29-Dec-1993
> > @@ -20,7 +23,7 @@ be reread whenever it changes.
> >
> >  I also added a "-e" option to crontab(1).  Nine people also sent me diffs
> >  to add this option, but I had already implemented it on my own.  I actually
> > -released an interrim version (V2.2, I think) for limited testing, and got a
> > +released an interim version (V2.2, I think) for limited testing, and got a
> 
> Should we really be in the business of modifying Vixie's changelog?

I'm replying here, but same goes for your comments on the other revision
(thanks for all those, btw).

Warning, rant ahead:

Our current SVN repo is in an inconsistent state thanks to the dubious
introduction of svn keywords. There are files in there, converted over
via cvs2svn and never touched since, but our presubmit checks want to
either see a $FreeBSD$ tag in modified files, or have fbsd:nokeywords
set. The latter is kinda a no-brainer for everything under contrib/ but
I'm struggling with what to do exactly for files that are non-contrib
and may or may not be non-code. Should the keywords be set on $subdir/*
or can I punch holes in the web of keywords as I see fit? (e.g.
$subdir/{README,CHANGES,foo.txt})

What's the point then anyway? SVN doesn't track files, but changesets.
Gah!

Oh wait, this ain't about the $FreeBSD$ keyword, but the typo-fix? I'm
sure that Vixie won't mind and do believe that correctness of spelling
is a worthy goal as we always tout the quality of our documentation.

FWIW, I'm not going to touch stuff under contrib/, etc.

> >  /*
> > - * Delete a rotated logfiles, when using clasic filenames.
> > + * Delete a rotated logfiles, when using classic filenames.
> 
> "a logfiles" is inconsistent.  Without looking up the implementation,
> I'm going to guess that "a rotated logfile" is correct.

When proofreading the spell-checked output I focused too narrowly on
just the typo that I fixed so that other typos in the same line/sentence
mostly went unnoticed. Will do better in the next couple of commits.

> >  */
> >  static void
> >  delete_clasiclog(const char *archive_dir, const char *namepart, int numlog_c)
> >
> > Modified: head/usr.sbin/ntp/doc/ntp.conf.5
> > ==============================================================================
> > --- head/usr.sbin/ntp/doc/ntp.conf.5    Fri Dec 30 10:45:00 2011        (r228989)
> > +++ head/usr.sbin/ntp/doc/ntp.conf.5    Fri Dec 30 10:58:14 2011        (r228990)
> > @@ -783,7 +783,7 @@ The remaining files are necessary only f
> >  Autokey protocol.
> >  .Pp
> >  Certificates imported from OpenSSL or public certificate
> > -authorities have certian limitations.
> >
> > *** DIFF OUTPUT TRUNCATED AT 1000 LINES ***
> 
> Hmm, that's unfortunate.
> Pulling out a svn client, it looks like:
> usr.sbin/pkg_install/lib/plist.c changes a misspelled form to the
> still-misspelled "occurrance" (not occurrence)

Thanks, will follow up on that!

> Thanks for doing this cleanup along with the encoding cleanup!
> 
> -Ben Kaduk
>