svn commit: r232271 - head/sys/kern

Dimitry Andric dim at FreeBSD.org
Wed Feb 29 07:46:59 UTC 2012


On 2012-02-28 23:11, Giovanni Trematerra wrote:
> On Tue, Feb 28, 2012 at 10:45 PM, Dimitry Andric <dim at freebsd.org> wrote:
>> Author: dim
>> Date: Tue Feb 28 21:45:21 2012
>> New Revision: 232271
>> URL: http://svn.freebsd.org/changeset/base/232271
...
> It introduces a style(9) violation, though.
> I think it should be in this way
> 
> pipe_chmod(struct file *fp, mode_t mode, struct ucred *active_cred,
>     struct thread *td)
> 
> Anyway that's not a problem I can take care of this and other style violations
> during next weeks.

Is there any interest in changing the other K&R definitions in this file
to C99?  Or does that cause too much churn?  I tried to make this change
as minimal as possible to make it compile.

Btw, style(9) doesn't say anything about a maximum line width, maybe
that should be added explicitly...:)


More information about the svn-src-head mailing list