svn commit: r232156 - head/sys/kern

Maxim Konovalov maxim at FreeBSD.org
Sat Feb 25 12:06:41 UTC 2012


Author: maxim
Date: Sat Feb 25 12:06:40 2012
New Revision: 232156
URL: http://svn.freebsd.org/changeset/base/232156

Log:
  o Reduce chances for integer overflow.
  o More verbose sysctl description added.
  
  MFC after:	2 weeks
  Sponsored by:	Nginx, Inc.

Modified:
  head/sys/kern/vfs_cache.c

Modified: head/sys/kern/vfs_cache.c
==============================================================================
--- head/sys/kern/vfs_cache.c	Sat Feb 25 11:07:32 2012	(r232155)
+++ head/sys/kern/vfs_cache.c	Sat Feb 25 12:06:40 2012	(r232156)
@@ -369,7 +369,7 @@ sysctl_debug_hashstat_nchash(SYSCTL_HAND
 			maxlength = count;
 	}
 	n_nchash = nchash + 1;
-	pct = (used * 100 * 100) / n_nchash;
+	pct = (used * 100) / (n_nchash / 100);
 	error = SYSCTL_OUT(req, &n_nchash, sizeof(n_nchash));
 	if (error)
 		return (error);
@@ -386,7 +386,7 @@ sysctl_debug_hashstat_nchash(SYSCTL_HAND
 }
 SYSCTL_PROC(_debug_hashstat, OID_AUTO, nchash, CTLTYPE_INT|CTLFLAG_RD|
     CTLFLAG_MPSAFE, 0, 0, sysctl_debug_hashstat_nchash, "I",
-    "nchash chain lengths");
+    "nchash statistics (number of total/used buckets, maximum chain length, usage percentage)");
 #endif
 
 /*


More information about the svn-src-head mailing list