svn commit: r231814 - in head/sys: kern sys

[Bruce Evans]

On Thu, 16 Feb 2012, Julian Elischer wrote:

> On 2/16/12 12:39 AM, Bruce Evans wrote:
>> On Thu, 16 Feb 2012, Eitan Adler wrote:
>> 
>>> Log:
>>>  Add a timestamp to the msgbuf output in order to determine when when
>>>  messages were printed.
>>> 
>>>  This can be enabled with the kern.msgbuf_show_timestamp sysctl
>> 
>> Apart from being fundamentally broken, this adds lots of bloat and
>> style bugs.  The msgbuf is a very low-level interface, and was
>> careful not to do stuff like this.  I'm still waiting for the previous
>> round of breakage of it, that replaces careful atomic ops by spinlocks,
>> to be backed out.  Code at this level cannot use any normal locking,
>>

> Bruce, this is a good example of a legitimate gripe going un-noticed because
> you didn't shout loud enough at the right time, at the right people.

But I did, in 2 replies to a reply to its commit message in June 2011.

> It's been about 20 years since we started working on this but I've finally
> come to the point of saying that we need you to do more when you see 
> problems.
> object officially if you think things should be backed out!
>
> your reasons here seem sound, so it's hard to see why you haven't been more
> public about it.

I don't use -current often enough to insist on things being backed out.
The technical argument will have to suffice.

Bruce