svn commit: r230869 - head/usr.sbin/daemon

[Andrey Zonov]

On 11.02.2012 14:35, Mikolaj Golub wrote:
>
> Thank you. Here are the patches I would like to commit if there are no
> objections or other suggestions:
>
> http://people.freebsd.org/~trociny/daemon/daemon.spawn.1.patch
> http://people.freebsd.org/~trociny/daemon/daemon.SIGTERM.1.patch
> http://people.freebsd.org/~trociny/daemon/daemon.restart.1.patch
>

There are two more suggestions, if you don't mind.

Use madvise(MADV_PROTECT).  It would be useful because of the daemon(8) 
should not leak or eats much memory.

Check return code from pidfile_write() function.  I saw many times when 
pid could not be written because of there is not enough free space (but 
file was created).  Unfortunately, I have no suggestions how to handle 
this properly.

-- 
Andrey Zonov