svn commit: r244236 - head/share/mk

[Ed Maste]

On 14 December 2012 19:13, Garrett Cooper <yanegomi at gmail.com> wrote:
> On Fri, Dec 14, 2012 at 4:03 PM, Ed Maste <emaste at freebsd.org> wrote:
>> Author: emaste
>> Date: Sat Dec 15 00:03:35 2012
>> New Revision: 244236
>> URL: http://svnweb.freebsd.org/changeset/base/244236
>
> ...
>
>> Modified: head/share/mk/sys.mk
>> ==============================================================================
>> --- head/share/mk/sys.mk        Fri Dec 14 23:13:06 2012        (r244235)
>> +++ head/share/mk/sys.mk        Sat Dec 15 00:03:35 2012        (r244236)
>> @@ -134,6 +134,8 @@ NM          ?=      nm
>>  OBJC           ?=      cc
>>  OBJCFLAGS      ?=      ${OBJCINCLUDES} ${CFLAGS} -Wno-import
>>
>> +OBJCOPY                ?=      objcopy
>> +
>>  PC             ?=      pc
>>  PFLAGS         ?=
>
>     This shouldn't be defined when !defined(%POSIX) is true. The
> .endif should be pulled down to just above SHELL?= according to what
> I'm reading in http://pubs.opengroup.org/onlinepubs/009695399/utilities/make.html
> .

Thanks for pointing this out; unfortunately it seems we have a bit of
a mess here already.  For one example see bin/155000; it looks it's
not even possible to correctly specify POSIX mode anyway.

I'd like to see us grow support for a POSIX-sys.mk as bde mentions in
155000, and we could then do away with all of the .if goo.  For now
though I'll move the .endif down.

>     Other spots in the tree where OBJCOPY?= is noted can be probably
> start to be reaped (thinking about sys/boot/, etc in particular). I
> have a PR open for some work Warner started with an initial patch that
> I've kind of been keeping up to date in git, but it needs to be
> updated now per this change (and also because I didn't notice that
> these variables weren't supposed to be defined when POSIX mode was
> on).

I'd think none of the other files should be affected by changes to
support POSIX mode.