svn commit: r244316 - head/sbin/savecore

[Pawel Jakub Dawidek]

Author: pjd
Date: Sun Dec 16 22:59:25 2012
New Revision: 244316
URL: http://svnweb.freebsd.org/changeset/base/244316

Log:
  Prefer snprintf() over sprintf().
  
  Obtained from:	WHEEL Systems

Modified:
  head/sbin/savecore/savecore.c

Modified: head/sbin/savecore/savecore.c
==============================================================================
--- head/sbin/savecore/savecore.c	Sun Dec 16 22:06:28 2012	(r244315)
+++ head/sbin/savecore/savecore.c	Sun Dec 16 22:59:25 2012	(r244316)
@@ -543,7 +543,7 @@ DoFile(const char *savedir, const char *
 
 	writebounds(bounds + 1);
 
-	sprintf(buf, "info.%d", bounds);
+	snprintf(buf, sizeof(buf), "info.%d", bounds);
 
 	/*
 	 * Create or overwrite any existing dump header files.
@@ -556,12 +556,12 @@ DoFile(const char *savedir, const char *
 	}
 	oumask = umask(S_IRWXG|S_IRWXO); /* Restrict access to the core file.*/
 	if (compress) {
-		sprintf(filename, "%s.%d.gz", istextdump ? "textdump.tar" :
-		    "vmcore", bounds);
+		snprintf(filename, sizeof(filename), "%s.%d.gz",
+		    istextdump ? "textdump.tar" : "vmcore", bounds);
 		fp = zopen(filename, "w");
 	} else {
-		sprintf(filename, "%s.%d", istextdump ? "textdump.tar" :
-		    "vmcore", bounds);
+		snprintf(filename, sizeof(filename), "%s.%d",
+		    istextdump ? "textdump.tar" : "vmcore", bounds);
 		fp = fopen(filename, "w");
 	}
 	if (fp == NULL) {