svn commit: r244112 - head/sys/kern

[Alfred Perlstein]

to all:

I am trying to take this offline with John so that we can discuss the 
reasoning behind the change and come to an agreement on how it is 
implemented, or if not to remove it.

-Alfred

On 12/12/12 7:46 AM, John Baldwin wrote:
> On Tuesday, December 11, 2012 2:08:14 am Alfred Perlstein wrote:
>> Author: alfred
>> Date: Tue Dec 11 07:08:14 2012
>> New Revision: 244112
>> URL: http://svnweb.freebsd.org/changeset/base/244112
>>
>> Log:
>>    Cleanup more of the kassert_panic.
>>    
>>    fix compile warnings on !amd64 and NULL derefs that would happen
>>    if kassert_panic() would return.
> This is one reason why having kassert not panic is such a bad idea.  There are
> tons of places where the compiler knows that panic() is __dead2, and there is
> no cleanup code to handle what happens when an invariant is violated.  This is
> not safe to run in the field unless your customers do not care about their
> data.  If you are interested in doing regression tests, I am using a very
> different approach for some locking regression tests I am working on in p4
> that allow you to use a wrapper around setjmp/longjmp to "catch" panics
> somewhat like exception handling in C++/Java (though much cruder).  However,
> evne that is only intended for testing, not for production cases where
> production data is at stake.
>