svn commit: r238990 - in head/sys: net netinet netinet6

Konstantin Belousov kostikbel at gmail.com
Wed Aug 22 11:45:01 UTC 2012


On Wed, Aug 22, 2012 at 02:17:05PM +0400, Gleb Smirnoff wrote:
> On Tue, Aug 21, 2012 at 12:50:14PM -0600, Kenneth D. Merry wrote:
> K> On Thu, Aug 02, 2012 at 13:57:50 +0000, Gleb Smirnoff wrote:
> K> > Author: glebius
> K> > Date: Thu Aug  2 13:57:49 2012
> K> > New Revision: 238990
> K> > URL: http://svn.freebsd.org/changeset/base/238990
> K> > 
> K> > Log:
> K> >   Fix races between in_lltable_prefix_free(), lla_lookup(),
> K> >   llentry_free() and arptimer():
> K> >   
> K> >   o Use callout_init_rw() for lle timeout, this allows us safely
> K> >     disestablish them.
> K> >     - This allows us to simplify the arptimer() and make it
> K> >       race safe.
> K> >   o Consistently use ifp->if_afdata_lock to lock access to
> K> >     linked lists in the lle hashes.
> K> >   o Introduce new lle flag LLE_LINKED, which marks an entry that
> K> >     is attached to the hash.
> K> >     - Use LLE_LINKED to avoid double unlinking via consequent
> K> >       calls to llentry_free().
> K> >     - Mark lle with LLE_DELETED via |= operation istead of =,
> K> >       so that other flags won't be lost.
> K> >   o Make LLE_ADDREF(), LLE_REMREF() and LLE_FREE_LOCKED() more
> K> >     consistent and provide more informative KASSERTs.
> K> >   
> K> >   The patch is a collaborative work of all submitters and myself.
> K> >   
> K> >   PR:		kern/165863
> K> >   Submitted by:	Andrey Zonov <andrey zonov.org>
> K> >   Submitted by:	Ryan Stone <rysto32 gmail.com>
> K> >   Submitted by:	Eric van Gyzen <eric_van_gyzen dell.com>
> K> 
> K> I'm running into this on stable/9, any plan on when this will get MFCed?
> 
> I'm sorry, but after 9.1-RELEASE. Too large change to run MFC prior to
> release.
> 
> I'd appreciate if you patch your stable/9 system manually and thus
> perform some testing prior to merge.

FYI, 9.1 was already branched. Not that I encourage you to make a commit
that would diverge the stable/9 from releng/9.1 while 9.1 is still rolling.
But the stall on stable/9 due to freeze was too long and IMO its longevity
is damaging.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20120822/4a176d13/attachment.pgp


More information about the svn-src-head mailing list