jemalloc and clang (was: Re: svn commit: r239462 - in head)

[Dimitry Andric]

On 2012-08-21 02:17, Jan Beich wrote:
...
> Time to revert r228540?
>
> Index: contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h
> ===================================================================
> --- contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h	(revision 239467)
> +++ contrib/jemalloc/include/jemalloc/jemalloc_FreeBSD.h	(working copy)
> @@ -56,10 +56,6 @@
>   #ifndef JEMALLOC_TLS_MODEL
>   #  define JEMALLOC_TLS_MODEL	/* Default. */
>   #endif
> -#ifdef __clang__
> -#  undef JEMALLOC_TLS_MODEL
> -#  define JEMALLOC_TLS_MODEL	/* clang does not support tls_model yet. */
> -#endif
>
>   #define	STATIC_PAGE_SHIFT	PAGE_SHIFT
>   #define	LG_SIZEOF_INT		2

Well, if Jason would like to support upstream jemalloc for different
versions of clang, it is probably better to to use __has_feature()
instead.

Jason, what do you think of the attached patch?  Or could we just remove
the whole #ifdef __clang__ part?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jemalloc-clang-tlsmodel-1.diff
Type: text/x-diff
Size: 671 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20120821/cc55b75d/jemalloc-clang-tlsmodel-1.bin