svn commit: r239066 - head/sys/boot/i386/libi386

John Baldwin jhb at freebsd.org
Mon Aug 6 12:14:06 UTC 2012


On Sunday, August 05, 2012 10:37:49 am Andrey V. Elsukov wrote:
> Author: ae
> Date: Sun Aug  5 14:37:48 2012
> New Revision: 239066
> URL: http://svn.freebsd.org/changeset/base/239066
> 
> Log:
>   Add offset field to the i386_devdesc structure to be compatible with
>   disk_devdesc structure. Update biosdisk driver to the new disk API.
> 
> Modified:
>   head/sys/boot/i386/libi386/Makefile
>   head/sys/boot/i386/libi386/biosdisk.c
>   head/sys/boot/i386/libi386/devicename.c
>   head/sys/boot/i386/libi386/libi386.h
> 
> Modified: head/sys/boot/i386/libi386/biosdisk.c
> 
==============================================================================
> --- head/sys/boot/i386/libi386/biosdisk.c	Sun Aug  5 14:11:42 2012	
(r239065)
> +++ head/sys/boot/i386/libi386/biosdisk.c	Sun Aug  5 14:37:48 2012	
(r239066)
>  
>  struct devsw biosdisk = {
> -    "disk", 
> -    DEVT_DISK, 
> -    bd_init,
> -    bd_strategy, 
> -    bd_open, 
> -    bd_close, 
> -    noioctl,
> -    bd_print,
> -    NULL
> +	"disk",
> +	DEVT_DISK,
> +	bd_init,
> +	bd_strategy,
> +	bd_open,
> +	bd_close,
> +	bd_ioctl,
> +	bd_print,
> +	NULL
>  };

You should not have mixed style changes in with code changes.  This makes the 
diff far harder to review and destroys history.  I asked you to not do this 
before.  *sigh*

-- 
John Baldwin


More information about the svn-src-head mailing list