svn commit: r239040 - in head/sys: fs/nfsclient fs/nwfs fs/smbfs nfsclient vm

[Attilio Rao]

On Sat, Aug 4, 2012 at 7:16 PM, Konstantin Belousov <kib at freebsd.org> wrote:
> Author: kib
> Date: Sat Aug  4 18:16:43 2012
> New Revision: 239040
> URL: http://svn.freebsd.org/changeset/base/239040
>
> Log:
>   Reduce code duplication and exposure of direct access to struct
>   vm_page oflags by providing helper function
>   vm_page_readahead_finish(), which handles completed reads for pages
>   with indexes other then the requested one, for VOP_GETPAGES().

The semantic of this new function is very questionable as I don't
think we have any other function that accepts error as in-parameter
(in particular if it does only a check).
The error check should really belong to the consumers IMHO (even if duplicate).

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein