svn commit: r227474 - head/sys/amd64/include
Dimitry Andric
dim at FreeBSD.org
Mon Nov 14 08:01:23 UTC 2011
On 2011-11-14 06:31, Peter Jeremy wrote:
> On 2011-Nov-12 20:16:07 +0000, David Chisnall <theraven at FreeBSD.org> wrote:
...
>> +#define SIG_ATOMIC_MIN LONG_MIN
>> +#define SIG_ATOMIC_MAX LONG_MAX
>
> 2) As far as I can see, all other defines in _stdint.h, across all
> architectures, have explicit lengths, so I believe this would be
> better specified as:
>
> #define SIG_ATOMIC_MIN INT64_MIN
> #define SIG_ATOMIC_MAX INT64_MAX
Why? On amd64, sig_atomic_t is defined as long, so LONG_MIN and
LONG_MAX are more logical. In fact, for all architectures, sig_atomic_t
is either int or long, so INTnn_MIN/MAX is rather strangely chosen.
More information about the svn-src-head
mailing list