svn commit: r221952 - head/sbin/geom/class/part

[Andrey V. Elsukov]

On 15.05.2011 20:59, Marcel Moolenaar wrote:
>> g_part_dumpconf() function does set both pair of parameters:
>> (start, end) and (offset, length). I do not see a way how one pair
>> can not be present in XML tree.
> 
> /* ... paging in non-commit details ... */
> 
> The point is that this is what's happening *now*. This is not
> what happened before. With support for logical partitions (i.e.
> the EBR scheme), the total partition bounds and the effective
> usable space are not the same. This is because the partition
> starts with an MBR look-alike. The usable space is therefore
> 1 sector less and start at offset 1 (0-based) from the start
> of the partition.
> 
> In any case: this particular scenario had to be handled and
> for that we have offset+size (the usable area, as per GEOM
> standards) and start+end (the total space occupied by the
> partition) separately. They do not represent the same info.
> 
> The start+end parameters did not exist before and I had to add
> that "later". To have the utility work with older kernels (that
> did not support the EBR scheme) I added the fall-back to using
> offset+length, because those two would encode what we needed
> in that case.

Yes, i looked in the commit log before doing this change.
And i did not do any changes in the kernel.  Removing code that never
triggers seems no so bad for me. I'm also do not see how MFC
can affect the stable branch, because this code only used inside
gpart(8) and it is problematic to reuse it from not here (and also it
never triggers in stable/8 too).

> As I said: I'm fine with the change, but please assess the
> consequences of dropping the fall-back, for it may be better
> to make this change on -current after 9-stable branched and
> without the MFC.

So, would you like to revert this change?

-- 
WBR, Andrey V. Elsukov

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20110515/4d4a84ee/signature.pgp