svn commit: r221449 - head/sys/geom/journal

[Andrey V. Elsukov]

On 05.05.2011 17:12, Pawel Jakub Dawidek wrote:
>> New Revision: 221449
>> URL: http://svn.freebsd.org/changeset/base/221449
>>
>> Log:
>>   Removed KASSERT, g_new_providerf() can not fail.
> 
> Well, the assertion was there to prepare us for times when
> g_new_providerf() will be able to fail. I was suspecting we might want
> to make g_new_providerf() to fail when the given name is already in use.

I think such change will break all code we have now :)
But now when it can not fail, KASSERT could slightly confuse those who
read code as example.

> In such case we use to create two identical entries in /dev/, not sure
> what we do now (panic?).

geom_dev prints out an error message.

-- 
WBR, Andrey V. Elsukov

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20110505/fc463c84/signature.pgp