svn commit: r219559 - in head/sys: amd64/linux32 compat/freebsd32 i386/linux kern

Alexander Leidinger Alexander at Leidinger.net
Sun Mar 13 13:15:36 UTC 2011


On Sat, 12 Mar 2011 22:24:09 -0800 Artem Belevich <fbsdlist at src.cx>
wrote:

> >> Modified: head/sys/i386/linux/syscalls.master
> >> -                                 l_handler_t handler); }
> >> +                                 void *handler); }
> >
> > What's wrong with l_handler_t?
> 
> I don't recall the details, but I believe that the way l_handler_t is
> defined resulted in compilation errors in generated glue code. Glue
> generation code relies on '*' before the argument name in order to
> tell scalars from pointers. l_handler_t was interpreted as a scalar
> and on i386 where l_handler_t is a pointer, it produced compilation
> warning.

What about documenting it with a comment nearby?

Bye,
Alexander.



More information about the svn-src-head mailing list