svn commit: r224551 - head/sys/powerpc/booke

Attilio Rao attilio at freebsd.org
Sun Jul 31 18:59:40 UTC 2011


2011/7/31 Marcel Moolenaar <marcel at xcllnt.net>:
>
> On Jul 31, 2011, at 11:27 AM, Attilio Rao wrote:
>
>> I actually submitted a better fix which does use .int.
>> I wasn't sure BETA1 was out, so I'm going to send a formal request now.
>
> Maybe we should just let it be. I don't see anything
> superior with using .int that .long didn't already
> fix. If anything, we could end up breaking stuff and
> then having to fix it again.
>
> Any reason to go back in and change it again that I
> can't see?

Besides extending the fix to arm and mips, size_t is typedefed as int
and not as long, thus I think it is more correct semantically.
Pratically speaking, for booke, it doesn't change anything though.

As you have the blanket on powerpc I'll do what you prefer for it, the
patch is here:
http://www.freebsd.org/~attilio/sintrcnt-fixup32.diff

Thanks,
Attilio


-- 
Peace can only be achieved by understanding - A. Einstein


More information about the svn-src-head mailing list