svn commit: r224216 - in head/sys: ia64/ia64 mips/mips powerpc/aim sparc64/sparc64

[Attilio Rao]

I think that the following patch may better reflect the definition of size_t:
http://www.freebsd.org/~attilio/sintrcnt-fixup32.diff

Do you think you can test it out?

Thanks,
Attilio

2011/7/25 Attilio Rao <attilio at freebsd.org>:
> Guys, I'm a bit out of that for a couple of days, flying to another
> continent, I'm not entirely sure the patch is right because I think we
> need an unified approach for specifying a 32-bits value, but you can
> check-in as a showstopper for the moment, I will make a better one in
> a couple of days.
>
> Attilio
>
> 2011/7/25 Nathan Whitehorn <nwhitehorn at freebsd.org>:
>> On 07/25/11 13:40, Andreas Tobler wrote:
>>>
>>> On 24.07.11 23:35, Nathan Whitehorn wrote:
>>>>
>>>> On 07/19/11 07:41, Attilio Rao wrote:
>>>>>
>>>>> Author: attilio
>>>>> Date: Tue Jul 19 12:41:57 2011
>>>>> New Revision: 224216
>>>>> URL: http://svn.freebsd.org/changeset/base/224216
>>>>>
>>>>> Log:
>>>>> On 64 bit architectures size_t is 8 bytes, thus it should use an 8 bytes
>>>>> storage.
>>>>> Fix the sintrcnt/sintrnames specification.
>>>>>
>>>>> No MFC is previewed for this patch.
>>>>>
>>>>
>>>> These also need to be .long on 32-bit PowerPC, otherwise this change
>>>> triggers kernel panics and faults in sysctl. Please change it as quickly
>>>> as possible.
>>>
>>> Like the below?
>>>
>>> I'll test and I could commit if ok. (Build and approval)
>>>
>>> Gruss,
>>> Andreas
>>>
>>> Index: locore32.S
>>> ===================================================================
>>> --- locore32.S (revision 224326)
>>> +++ locore32.S (working copy)
>>> @@ -91,13 +91,13 @@
>>> GLOBAL(intrnames)
>>> .space INTRCNT_COUNT * (MAXCOMLEN + 1) * 2
>>> GLOBAL(sintrnames)
>>> - .word INTRCNT_COUNT * (MAXCOMLEN + 1) * 2
>>> + .long INTRCNT_COUNT * (MAXCOMLEN + 1) * 2
>>>
>>> .align 4
>>> GLOBAL(intrcnt)
>>> .space INTRCNT_COUNT * 4 * 2
>>> GLOBAL(sintrcnt)
>>> - .word INTRCNT_COUNT * 4 * 2
>>> + .long INTRCNT_COUNT * 4 * 2
>>>
>>> .text
>>> .globl btext
>>
>> Exactly like that.
>> -Nathan
>>
>
>
>
> --
> Peace can only be achieved by understanding - A. Einstein
>



-- 
Peace can only be achieved by understanding - A. Einstein