svn commit: r224218 - in head/sys: kern sys
Attilio Rao
attilio at FreeBSD.org
Tue Jul 19 14:58:00 UTC 2011
Author: attilio
Date: Tue Jul 19 14:57:59 2011
New Revision: 224218
URL: http://svn.freebsd.org/changeset/base/224218
Log:
Remove pc_name member of struct pcpu.
pc_name is only included when KTR option is and it does introduce a
subdle KBI breakage that totally breaks vmstat when world and kernel are
not in sync.
Besides, it is not used somewhere.
In collabouration with: pluknet
Reviewed by: jhb
Approved by: re (kib)
Modified:
head/sys/kern/subr_pcpu.c
head/sys/sys/pcpu.h
Modified: head/sys/kern/subr_pcpu.c
==============================================================================
--- head/sys/kern/subr_pcpu.c Tue Jul 19 13:00:30 2011 (r224217)
+++ head/sys/kern/subr_pcpu.c Tue Jul 19 14:57:59 2011 (r224218)
@@ -92,9 +92,6 @@ pcpu_init(struct pcpu *pcpu, int cpuid,
cpu_pcpu_init(pcpu, cpuid, size);
pcpu->pc_rm_queue.rmq_next = &pcpu->pc_rm_queue;
pcpu->pc_rm_queue.rmq_prev = &pcpu->pc_rm_queue;
-#ifdef KTR
- snprintf(pcpu->pc_name, sizeof(pcpu->pc_name), "CPU %d", cpuid);
-#endif
}
void
Modified: head/sys/sys/pcpu.h
==============================================================================
--- head/sys/sys/pcpu.h Tue Jul 19 13:00:30 2011 (r224217)
+++ head/sys/sys/pcpu.h Tue Jul 19 14:57:59 2011 (r224218)
@@ -165,9 +165,6 @@ struct pcpu {
u_int pc_cpuid; /* This cpu number */
STAILQ_ENTRY(pcpu) pc_allcpu;
struct lock_list_entry *pc_spinlocks;
-#ifdef KTR
- char pc_name[PCPU_NAME_LEN]; /* String name for KTR */
-#endif
struct vmmeter pc_cnt; /* VM stats counters */
long pc_cp_time[CPUSTATES]; /* statclock ticks */
struct device *pc_device;
More information about the svn-src-head
mailing list