svn commit: r217308 - head/sbin/hastd

[Pawel Jakub Dawidek]

On Wed, Jan 12, 2011 at 06:10:19PM +0200, Kostik Belousov wrote:
> On Wed, Jan 12, 2011 at 02:38:17PM +0000, Pawel Jakub Dawidek wrote:
> > Author: pjd
> > Date: Wed Jan 12 14:38:17 2011
> > New Revision: 217308
> > URL: http://svn.freebsd.org/changeset/base/217308
> > 
> > Log:
> >   Add a note that when custom signal handler is installed for a signal,
> >   signal action is restored to default in child after fork(2).
> >   In this case there is no need to do anything with dummy SIGCHLD handler,
> >   because after fork(2) it will be automatically reverted to SIG_IGN.
> >   
> >   Obtained from:	Wheel Systems Sp. z o.o. http://www.wheelsystems.com
> >   MFC after:	3 days
> > 
> > Modified:
> >   head/sbin/hastd/hooks.c
> > 
> > Modified: head/sbin/hastd/hooks.c
> > ==============================================================================
> > --- head/sbin/hastd/hooks.c	Wed Jan 12 14:35:29 2011	(r217307)
> > +++ head/sbin/hastd/hooks.c	Wed Jan 12 14:38:17 2011	(r217308)
> > @@ -372,6 +372,11 @@ hook_execv(const char *path, va_list ap)
> >  		descriptors();
> >  		PJDLOG_VERIFY(sigemptyset(&mask) == 0);
> >  		PJDLOG_VERIFY(sigprocmask(SIG_SETMASK, &mask, NULL) == 0);
> > +		/*
> > +		 * Dummy handler set for SIGCHLD in the parent should be
> > +		 * changed after fork(2) automatically to the default SIG_IGN,
> > +		 * so there is no need to do anything with it.
> > +		 */
> >  		execv(path, args);
> >  		pjdlog_errno(LOG_ERR, "Unable to execute %s", path);
> >  		exit(EX_SOFTWARE);
> Fork does not change the disposition of the signals.
> Exec family of the functions indeed reset the signals with handler
> to default disposition.

You are right, thanks.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-head/attachments/20110112/aa1084c1/attachment.pgp