svn commit: r217241 - head/sys/dev/acpica/Osd

Jung-uk Kim jkim at FreeBSD.org
Mon Jan 10 21:09:38 UTC 2011


Author: jkim
Date: Mon Jan 10 21:09:38 2011
New Revision: 217241
URL: http://svn.freebsd.org/changeset/base/217241

Log:
  Remove impossible error conditions.

Modified:
  head/sys/dev/acpica/Osd/OsdInterrupt.c

Modified: head/sys/dev/acpica/Osd/OsdInterrupt.c
==============================================================================
--- head/sys/dev/acpica/Osd/OsdInterrupt.c	Mon Jan 10 21:01:41 2011	(r217240)
+++ head/sys/dev/acpica/Osd/OsdInterrupt.c	Mon Jan 10 21:09:38 2011	(r217241)
@@ -104,8 +104,7 @@ AcpiOsInstallInterruptHandler(UINT32 Int
 	KASSERT(sc != NULL && sc->acpi_dev != NULL,
 	    ("can't find ACPI device to register interrupt"));
 
-	if (InterruptNumber < 0 || InterruptNumber > 255 ||
-	    ServiceRoutine == NULL)
+	if (InterruptNumber > 255 || ServiceRoutine == NULL)
 		return_ACPI_STATUS (AE_BAD_PARAMETER);
 
 	ai = malloc(sizeof(*ai), M_ACPIINTR, M_WAITOK | M_ZERO);
@@ -181,8 +180,7 @@ AcpiOsRemoveInterruptHandler(UINT32 Inte
 	KASSERT(sc != NULL && sc->acpi_dev != NULL,
 	    ("can't find ACPI device to deregister interrupt"));
 
-	if (InterruptNumber < 0 || InterruptNumber > 255 ||
-	    ServiceRoutine == NULL)
+	if (InterruptNumber > 255 || ServiceRoutine == NULL)
 		return_ACPI_STATUS (AE_BAD_PARAMETER);
 	mtx_lock(&acpi_intr_lock);
 	SLIST_FOREACH(ai, &acpi_intr_list, ai_link)


More information about the svn-src-head mailing list